From 398392445e31949e97b4597e3157103d221fff47 Mon Sep 17 00:00:00 2001
From: pavel <pavel.larkin@ikeja.co.za>
Date: Sat, 25 Oct 2025 05:00:19 +0300
Subject: [PATCH] 0500

---
 files/ansible-playbooks/sot-updater.yml | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/files/ansible-playbooks/sot-updater.yml b/files/ansible-playbooks/sot-updater.yml
index 8c73f58..9235a40 100644
--- a/files/ansible-playbooks/sot-updater.yml
+++ b/files/ansible-playbooks/sot-updater.yml
@@ -198,24 +198,25 @@
       failed_when: false
       ignore_errors: true
 
-    - name: Dev1 | Normalize banner (use shell string ops)
+    - name: Dev1 | Normalize banner → X.X.X-rYYYY (POSIX tools)
       delegate_to: localhost
       shell: |
-        line="{{ dev1_banner.stdout | trim }}"
-        # cut at the first pipe if present
-        line="${line%%|*}"
-        # replace the first space before 'rev' with a dash
-        line="${line/ rev /-r}"
-        # remove any extra spaces after the number
-        line="$(echo "$line" | awk '{print $1}')"
-        echo "$line"
-      register: dev1_fw_clean_shell
+        printf '%s\n' "{{ dev1_banner.stdout | trim }}" \
+        | awk -F '|' '{print $1}' \
+        | sed -E 's/[[:space:]]+rev[[:space:]]+/-r/' \
+        | grep -Eo '[0-9]+\.[0-9]+\.[0-9]+-r[0-9]+' || true
+      register: dev1_fw_clean_cmd
       changed_when: false
 
+    - name: Dev1 | Set final fw string
+      delegate_to: localhost
+      set_fact:
+        dev1_fw_clean: "{{ dev1_fw_clean_cmd.stdout | trim }}"
+
     - name: Debug Dev1 normalized firmware
       delegate_to: localhost
       debug:
-        msg: "Dev1 fw_version  {{ dev1_fw_clean_shell | default('N/A') }}"
+        msg: "Dev1 fw_version  {{ dev1_fw_clean | default('N/A') }}"
 
     - name: Publish Dev1 fw_version
       delegate_to: localhost